Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS 12 #16448

Merged
merged 2 commits into from
Oct 2, 2023
Merged

MacOS 12 #16448

merged 2 commits into from
Oct 2, 2023

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Oct 2, 2023 •
edited
Loading

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Related shivammathur/setup-php#770

Thanks

@Jeckerson Jeckerson self-assigned this Oct 2, 2023
@Jeckerson Jeckerson marked this pull request as ready for review October 2, 2023 09:29
@Jeckerson Jeckerson requested a review from niden October 2, 2023 09:29
@Jeckerson Jeckerson added the enhancement Enhancement to the framework label Oct 2, 2023
@Jeckerson
Copy link
Member Author

@niden Single, second based, test failed, all another things works fine. Merging.

@Jeckerson Jeckerson merged commit da8d71b into 5.0.x Oct 2, 2023
75 of 76 checks passed
@Jeckerson Jeckerson deleted the macos-12 branch October 2, 2023 09:31
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden Awaiting requested review from niden

Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework
Projects
Phalcon v5
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @niden